Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPS mode data size feature #567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/configs/wordlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -778,4 +778,5 @@ async
AsyncMode
AsyncResponseURL
AsyncWaitToCollectMin
Knative's
Knative's
RpsDataSizeMB
1 change: 1 addition & 0 deletions cmd/config_dirigent_dandelion_rps.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"RpsRuntimeMs": 10,
"RpsMemoryMB": 2048,
"RpsIterationMultiplier": 80,
"RpsDataSizeMB": 0.00,

"TracePath": "data/traces/example",
"Granularity": "minute",
Expand Down
1 change: 1 addition & 0 deletions cmd/config_dirigent_rps.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"RpsRuntimeMs": 10,
"RpsMemoryMB": 2048,
"RpsIterationMultiplier": 80,
"RpsDataSizeMB": 0.00,

"TracePath": "data/traces/example",
"Granularity": "minute",
Expand Down
1 change: 1 addition & 0 deletions cmd/config_knative_rps.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"RpsRuntimeMs": 10,
"RpsMemoryMB": 2048,
"RpsIterationMultiplier": 80,
"RpsDataSizeMB": 0.00,

"TracePath": "data/traces/example",
"Granularity": "minute",
Expand Down
4 changes: 3 additions & 1 deletion docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
| RpsRuntimeMs | int | >=0 | 0 | Requested execution time |
| RpsMemoryMB | int | >=0 | 0 | Requested memory |
| RpsIterationMultiplier | int | >=0 | 0 | Iteration multiplier for RPS mode |
| RpsDataSizeMB | float64 | >= 0 | 0 | Amount of random data (same for all requests) to embed into each request |
| TracePath | string | string | data/traces | Folder with Azure trace dimensions (invocations.csv, durations.csv, memory.csv) |
| Granularity | string | minute, second | minute | Granularity for trace interpretation[^2] |
| OutputPathPrefix | string | any | data/out/experiment | Results file(s) output path prefix |
Expand Down Expand Up @@ -55,7 +56,8 @@ Lambda; https://aws.amazon.com/about-aws/whats-new/2018/10/aws-lambda-supports-f

[^6]: Dirigent specific

[^7] It is recommended that the first 10% of cold starts are discarded from the experiment results for low cold start RPS.
[^7] It is recommended that the first 10% of cold starts are discarded from the experiment results for low cold start
RPS.

---

Expand Down
1 change: 1 addition & 0 deletions pkg/config/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ type LoaderConfiguration struct {
RpsRuntimeMs int `json:"RpsRuntimeMs"`
RpsMemoryMB int `json:"RpsMemoryMB"`
RpsIterationMultiplier int `json:"RpsIterationMultiplier"`
RpsDataSizeMB float64 `json:"RpsDataSizeMB"`

TracePath string `json:"TracePath"`
Granularity string `json:"Granularity"`
Expand Down
30 changes: 27 additions & 3 deletions pkg/driver/clients/http_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package clients

import (
"bytes"
"crypto/rand"
"encoding/json"
log "github.com/sirupsen/logrus"
"github.com/vhive-serverless/loader/pkg/common"
Expand Down Expand Up @@ -33,6 +34,23 @@ func newHTTPInvoker(cfg *config.LoaderConfiguration) *httpInvoker {
}
}

var payload []byte = nil

func CreateRequestPayload(sizeInMB float64) *bytes.Buffer {
byteCount := int(sizeInMB * 1024.0 * 1024.0) // MB -> B

if payload == nil {
payload = make([]byte, byteCount)

n, err := rand.Read(payload)
if err != nil || n != byteCount {
log.Errorf("Failed to generate random %d bytes.", byteCount)
}
}

return bytes.NewBuffer(payload)
}

func (i *httpInvoker) Invoke(function *common.Function, runtimeSpec *common.RuntimeSpecification) (bool, *mc.ExecutionRecord) {
isDandelion := strings.Contains(strings.ToLower(i.cfg.Platform), "dandelion")
isKnative := strings.Contains(strings.ToLower(i.cfg.Platform), "knative")
Expand All @@ -48,8 +66,6 @@ func (i *httpInvoker) Invoke(function *common.Function, runtimeSpec *common.Runt
////////////////////////////////////
// INVOKE FUNCTION
////////////////////////////////////
start := time.Now()
record.StartTime = start.UnixMicro()

requestBody := &bytes.Buffer{}
/*if body := composeDandelionMatMulBody(function.Name); isDandelion && body != nil {
Expand All @@ -58,8 +74,16 @@ func (i *httpInvoker) Invoke(function *common.Function, runtimeSpec *common.Runt
if body := composeBusyLoopBody(function.Name, function.DirigentMetadata.Image, runtimeSpec.Runtime, function.DirigentMetadata.IterationMultiplier); isDandelion && body != nil {
requestBody = body
}
if i.cfg.RpsTarget != 0 {
ts := time.Now()
requestBody = CreateRequestPayload(i.cfg.RpsDataSizeMB)
log.Debugf("Took %v to generate request body.", time.Since(ts))
}

start := time.Now()
record.StartTime = start.UnixMicro()

req, err := http.NewRequest("GET", "http://"+function.Endpoint, requestBody)
req, err := http.NewRequest("POST", "http://"+function.Endpoint, requestBody)
if err != nil {
log.Errorf("Failed to create a HTTP request - %v\n", err)

Expand Down
2 changes: 2 additions & 0 deletions pkg/driver/deployment/dirigent.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ func deployDirigent(function *common.Function, controlPlaneAddress string, busyL
log.Error("Function registration returned no data plane(s).")
return
}

log.Debugf("Got the following endpoints: %v", endpoints)
function.Endpoint = endpoints[rand.Intn(len(endpoints))]

checkForRegistration(controlPlaneAddress, function.Name, prepullMode)
Expand Down
Loading