Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint CI to work with multiple modules #135

Merged
merged 5 commits into from
Apr 27, 2022

Conversation

harshitgarg22
Copy link
Contributor

Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! thank you, the workaround seems to work nicely. We do need to brush up the code though because most of these checks fail.

I can see there are some simple linter errors in the code (shown in the GH review mode) and there is also another type of errors with missing go.sum entry. Do you know how to fix the latter?

@harshitgarg22
Copy link
Contributor Author

Great! thank you, the workaround seems to work nicely. We do need to brush up the code though because most of these checks fail.

I can see there are some simple linter errors in the code (shown in the GH review mode) and there is also another type of errors with missing go.sum entry. Do you know how to fix the latter?

The latter I believe should be fixed by running go mod tidy where go version is 1.16.

Also note that the checks would run for all folders everytime a PR is made, irrespective of which part of the codebase is modified.

harshitgarg22 and others added 3 commits April 26, 2022 18:42
@ustiugov ustiugov force-pushed the golangci-multimod branch from ebbaf3a to d72daea Compare April 26, 2022 18:58
@harshitgarg22 harshitgarg22 requested a review from ustiugov April 27, 2022 11:09
@ustiugov ustiugov merged commit f8f3fc1 into main Apr 27, 2022
@ustiugov ustiugov deleted the golangci-multimod branch April 27, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants