Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance chart features, add daemonset, add linting ci #24

Merged
merged 9 commits into from
May 12, 2022

Conversation

maxime1907
Copy link
Contributor

No description provided.

@mstein11
Copy link
Contributor

Thanks for contributing!

Copy link
Contributor

@mstein11 mstein11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I think your changes greatly improve the docker-hub-rate-limit-exporter. I especially like the inclusion of helm tests - I didn't know this tool before! Great work!

However, there are a few issues with your changes that need to be addressed before merging. If you need help with fixing the issues because of time constraints please let me know. I really would love for this to be merged soon. :-)

Copy link
Contributor

@mstein11 mstein11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your quick response in fixing the review comments from earlier :-)
I think we can merge this MR once the tests are green and once we revert the changes regarding multiple deployments / multi-account-feature, as elaborated on in the comment.

If you want to help with the multi-accoount feature, please open another pull request so we can track (and merge) the progress separately.

Thanks again for your contribution :-)

@maxime1907 maxime1907 changed the title feat(chart): enhance features, add daemonset, update chart feat: enhance chart features, add daemonset, add linting ci May 12, 2022
@mstein11 mstein11 merged commit 173815f into viadee:main May 12, 2022
@mstein11
Copy link
Contributor

Thanks again for contributing :-)
We will probably announce the new version over twitter from this account: https://twitter.com/cloudviadee
If you want to be mentioned as contributor there let me know your twitter handle!

@maxime1907
Copy link
Contributor Author

Thanks again for contributing :-) We will probably announce the new version over twitter from this account: https://twitter.com/cloudviadee If you want to be mentioned as contributor there let me know your twitter handle!

No problem, you can mention my github username 🙂

@maxime1907 maxime1907 deleted the enhance-chart branch May 12, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants