Align the Go version and update Go to 1.23 #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
marcofranssen
commented
Jan 20, 2025
| @@ -1,7 +1,6 @@ | |||
| module github.com/viaduct-ai/kustomize-sops | |||
|
|
|||
| go 1.22 | |||
| toolchain go1.22.9 | |||
There was a problem hiding this comment.
result of go mod tidy
marcofranssen
commented
Jan 20, 2025
| @@ -35,7 +35,8 @@ jobs: | |||
| - name: Set up Go | |||
| uses: actions/setup-go@v5 | |||
| with: | |||
| go-version: 1.21 | |||
| go-version-file: go.mod | |||
There was a problem hiding this comment.
automatically take the version from go.mod
This will also prevent things from running out of sync like currently is the situation.
marcofranssen
commented
Jan 20, 2025
| @@ -14,17 +14,17 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest] | |||
| go: [1.21] | |||
There was a problem hiding this comment.
As only one version is tested, removed the matrix for this and leverage the go.mod file to run with the version as defined in there, preventing duplication of the go version in various places that ran out of sync.
|
@devstein can you help out reviewing this and getting this in? I'm planning on more optimizations to get rid of CVEs and better Docker image. |
devstein
approved these changes
Jan 28, 2025
|
Thank you @marcofranssen! I missed these notifications |
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #271 as well. Trying to cleanup the image, build process and get bit of control on vulnerabilities in the image.