Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3152: Clarify info about preinstall script #3704

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Nov 26, 2024

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Nov 26, 2024
@@ -213,6 +213,7 @@ If you created a <FILE>viam-provisioning.json</FILE>, specify its location when

You must have flashed a 64-bit image to your SD card and customized at least the hostname when prompted by the Raspberry Pi Imager.

Any customizations for the image must be applied in the RPi Imager tool when creating the SD card.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Otterverse I don't know if this is even needed. Are there other customizations aside from what we say in the next line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the wording was already here (I mean, it's literally the two paragraphs below this.) But apparently people were still overlooking this and running into problems. So the request was to somehow make it even MORE obvious that customization is REQUIRED.

I'm not sure exactly what that looks like. Maybe a screenshot from the RPi Imager's dialog about customization and the "yes" button circled/highlighted? Maybe just some red highlights on the next below or the word "customized" in the paragraph or two above.

@viambot
Copy link
Member

viambot commented Nov 26, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants