-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update resources.md #452
Update resources.md #452
Conversation
Added Frontend Mentor to the list of resources of JavaScript directory #444
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link works perfectly fine. Thanks for contributing to this repository.
Keep contribute🚀.
Thank you sir , But I am unable to merge the changes because of the warning saying "REVIEW REQUIRED" and saying "At least 1 approving review is required by reviewers with write access" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to merge the changes please review again and help me to merge because it's saying "REVIEW REQUIRED" and "At least 1 approving review is required by reviewers with write access"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really appreciate your contribution. The resources you provide are great and I am thankful for your help. Thank you!
Keep Contribute 🚀.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really appreciate your contribution. The resources you provide are great and I am thankful for your help. Thank you!
Sir I can not merge the pull request as it showing me that "At least 1 approving review is required by reviewers with write access" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do some little bit of changes to it then I will review it again.
Added frontend mentor link , updated Conferences heading and also updated books heading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making changes.
Sorry Brother, I try my best but it's okay it happens sometimes. But Keep
Contributing and explore some important resources like these ones:
https://goodfirstissue.dev/
https://os.pradumnasaraf.dev/#/
https://finder.eddiehub.io/
https://www.firsttimersonly.com/
…On Sun, 6 Aug 2023 at 11:09, Aditya Srivastava ***@***.***> wrote:
Thank you sir , But I am unable to merge the changes because of the
warning saying "REVIEW REQUIRED"
—
Reply to this email directly, view it on GitHub
<#452 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXIGEAR2635GSDLMEB2D3UDXT4UY5ANCNFSM6AAAAAA3FVFMDY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Thank you |
Added Frontend Mentor to the list of resources of JavaScript directory #444