Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resources.md #452

Closed
wants to merge 2 commits into from
Closed

Update resources.md #452

wants to merge 2 commits into from

Conversation

AdityaSrivastava185
Copy link

Added Frontend Mentor to the list of resources of JavaScript directory #444

Added Frontend Mentor to the list of resources of JavaScript directory #444
Copy link

@beRajeevKumar beRajeevKumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link works perfectly fine. Thanks for contributing to this repository.
Keep contribute🚀.

@AdityaSrivastava185
Copy link
Author

AdityaSrivastava185 commented Aug 6, 2023

Thank you sir , But I am unable to merge the changes because of the warning saying "REVIEW REQUIRED" and saying "At least 1 approving review is required by reviewers with write access"
Please Help and review my changes

Copy link
Author

@AdityaSrivastava185 AdityaSrivastava185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to merge the changes please review again and help me to merge because it's saying "REVIEW REQUIRED" and "At least 1 approving review is required by reviewers with write access"

Copy link

@beRajeevKumar beRajeevKumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate your contribution. The resources you provide are great and I am thankful for your help. Thank you!
Keep Contribute 🚀.

Copy link

@beRajeevKumar beRajeevKumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate your contribution. The resources you provide are great and I am thankful for your help. Thank you!

@AdityaSrivastava185
Copy link
Author

AdityaSrivastava185 commented Aug 6, 2023

Sir I can not merge the pull request as it showing me that "At least 1 approving review is required by reviewers with write access"
please merge the pull request because it's approved
Only member with reviewer with write access can merge the pull request

Copy link

@beRajeevKumar beRajeevKumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do some little bit of changes to it then I will review it again.

Added frontend mentor link , updated Conferences heading and also updated books heading
Copy link
Author

@AdityaSrivastava185 AdityaSrivastava185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review please

Copy link

@beRajeevKumar beRajeevKumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making changes.

@AdityaSrivastava185
Copy link
Author

AdityaSrivastava185 commented Aug 6, 2023

Screenshot 2023-08-07 005036
Saying this , Please help

@beRajeevKumar
Copy link

beRajeevKumar commented Aug 6, 2023 via email

@AdityaSrivastava185
Copy link
Author

Thank you

@AdityaSrivastava185 AdityaSrivastava185 closed this by deleting the head repository Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants