Fix a 43-year old bug in reciter where the unvoiced affricate/non-palate prefix doesn't correctly handle the 2-letter cases. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate prefix doesn't correctly handle the 2-letter cases. This fixes words like 'thurible', 'shuriken', and 'ashura'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a 43-year old bug in reciter where the unvoiced affricate/non-palate prefix doesn't correctly handle the 2-letter cases.
In the original 6502 code, there is a missing
DEXopcode and a missingLDA $8d00, Xopcode to load the previous letter into the accumulator, so the 2-letter test case will always fail as it compares the same letter both toH, and then later toC,T, andS.This means the rule
@(UR)#=UH4Rwill not correctly trigger on segments with the two letter preficesCHTHandSH, which is incorrect according to the NRL Report 7948 that the reciter rule set is based on.This fixes words like 'thurible', 'shuriken', and 'ashura' (and likely others) where without this fix they will be incorrectly pronounced as 'thyurible' 'shyuriken' and 'ashyura'.