Fix some more 43-year old bugs: typos in the rules #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ispronounce "wasn't" as "wasm't"
Lord-Nightmare
changed the title
…line above, and causes 'them' to be pronounced incorrectly.
Lord-Nightmare
changed the title
…smission or storage error, and breaks pronunciation of the standalone letter 'x'
|
Interestingly, these typos are specific to the c64 version of S.A.M.! The atari version and the apple2 version both have these rules correct (there are actually a number of other errors specific to the c64 ruleset, missing prefix spaces for word boundaries, etc, but fixing these is much more involved as it will require changing the offsets table which points to the start of each letter rule) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo in one of the S rules which would mispronounce "wasn't" as "wasm't"