fix glyph rendering, handle multiple cmap #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
render some glyph (eg number 2, century.ttf) is not correct with the old code. I fixed it in the Typography lib, and contribute back here. I rename some vars, just try to keep it sync with the Typography
some fonts, eg Century.ttf, have multiple cmap table, in this case, we must select the most proper one (else this will give an error). So I added PlatformId and EncodingId to the cmap CharacterMap entry. Here, I test only with Windows font.
I try to keep sync with the Typography, for future contribution :)
|
@vidstige, |
|
Thanks! Don't know what's up with the appveyor build... 🤔 Thanks so much for fixing this bug. Will look through code when I get time over. |
|
Master is also failing, so don't worry too much over that. @tocsoft set this up initially. At least the travis build is passing 👌 |
|
@vidstige , |
|
@prepare no, I don't. Don't even have VS2017 😬 If you have the changes, feel free to commit. Otherwise I'll might do it whenever I get some time over, if you keep reminding me. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version has bugs. It can't render 'Century.ttf' font.
so I fixed it. Descriptions are in each node 01-05
pic 1: '2' glyph, Century font, Gdi+ version
pic 2: Century font, 240 pt, Notepad [1] vs Typography [2], see red rectangle, this is a characteristic of this glyph (starts with OFF-CURVE point and ends with OFF-CURVE point)
@vidstige, It would be great if you upgrade the project to VS2017 :)