Ruby 2.7 support: Switch to Addressable.URI.escape away from obsolete URI.escape #43
Conversation
johnphamvan
changed the title
|
@vifreefly Hi! Could you please take a look at this PR when you have a free moment? Thanks for creating and maintaining this project! |
|
@vifreefly Hi. Could you please provide feedback or consider accepting this PR? Also, would you be interested in having some help maintaining this project? |
vifreefly
force-pushed
the
master
branch
3 times, most recently
from
e97c41e
to
649c1a8
Compare
|
@vifreefly any updates here? |
|
Just hit this myself after upgrading to 2.7. I presume the best course of action is to fork this as it doesn't seem to be maintained anymore |
|
@doutatsu We're considering maintaining a fork, adding some test coverage, and adding Chrome CDP support via the ferrum gem. Be interested in helping? |
|
@johnphamvan Potentially. Need to evaluate what other gems are out there, as I had another one recommended, so would have to see if I want to stick with Kimura |
|
Hello @johnphamvan & @doutatsu I do plan to start maintaining the project again soon, but at the moment I don't have enough time for it. We could start with @johnphamvan PR (great work by the way). What will you say? |
…ed some development gems Fixed Ruby 2.7 warning for keyword arguments
johnphamvan
force-pushed
the
feature/ruby-2-7-support
branch
from
6797865
to
58c971b
Compare
|
@vifreefly Squashed and updated CHANGELOG.md. |
|
Hi @vifreefly thanks for making this library. Would you consider adding some maintainers to this project to keep it moving along? It'd be nice to have it working on Ruby 3 without needing forks. |
|
I'd be interested in helping out as a contributor as well! |
|
Hey guys, I would love to see your contributions on Tanakai (Kimurai fork), it already got support to Chrome CDP. |
Addresses #42