-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates From The Active Fork: Ruby 3 Support, Bug Fixes, New Drivers (Cuprite, Apparition), Test Updates #70
base: master
Are you sure you want to change the base?
Conversation
add data attribute to crawl! method
…ed some development gems Fixed Ruby 2.7 warning for keyword arguments
@jkeen is your branch effectively the successor / continuation of Kimurai at this point? Seems like this has been somewhat abandoned, but updates are very much needed in some areas. If so, would you mind opening an issues area for further work/collab and potential issue reporting? |
@vifreefly Is this project effectively abandoned? The villagers are plotting an uprising @ylluminate It's not intended to be… but I guess it could? It's super frustrating when great OSS projects get semi-abandoned like this and everyone has little islands of fixes that never get merged back upstream. All I did with this branch is combine two islands to get my own thing working, and I PR'd in hopes it would get merged or at least to let other people find and benefit from it. That all being said I don't really have the bandwidth to take over this project, so I hesitate to open up an issues tab inviting assumptions that I'm the maintainer… but caution thrown to the wind, I just did that. Issues are open, discussions are open, PRs ARE WELCOME. I definitely have time to push a few buttons here and there. |
Fix: double splat keyword arguments for Saver.new
So it kinda seems that the choice has now settled to https://github.com/jkeen/kimuraframework vs https://github.com/glaucocustodio/tanakai for succession from a cursory glance... And this thread makes it clear that |
@ylluminate It does seem that way. 🤴 I'm not promising a bunch of new features and things moving forward, but I will do my damnedest to at least respond to PRs and things. I just merged in some commits from the tanakai fork onto my kimurai fork. I kept the original name because it seems like tanakai is abandoned as well and we might as well keep this mess of abandoning a touch simpler moving forward. |
hey @jkeen, Tanakai is not abandoned, it's just that I am focusing in other stuff recently, but contributions are welcome :), we can create an org to host it, so you have write access as well |
Allow passing
data: {}
into crawl! from this branchhttps://github.com/dtengeri/kimuraframework
Ruby 3 compatibility from this branch:
https://github.com/n-studio/kimuraframework
Hopefully this PR gets merged into the main branch so everyone can benefit but if not I hope this helps a future traveler by providing a branch that merges two useful disparate branches.