Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new extension vike-react-redux (closes #87) #161

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

feat: new extension vike-react-redux (closes #87) #161

wants to merge 10 commits into from
+864 −14

Conversation

phonzammi
Copy link
Member

@phonzammi phonzammi commented Jan 28, 2025 •
edited by brillout
Loading

#87

@brillout
Copy link
Member

Neat! Let me know when you want me to have a look at it.

@phonzammi
Copy link
Member Author

I think the basic integration is good enough, but I’m not too familiar with more complex use cases. Let me know what you think.

I’ll polish the README once we’ve covered everything.

@brillout brillout changed the title feat: new extension vike-react-redux feat: new extension vike-react-redux (fix #87) Jan 30, 2025
@brillout brillout changed the title feat: new extension vike-react-redux (fix #87) feat: new extension vike-react-redux (closes #87) Jan 30, 2025
@brillout brillout mentioned this pull request Jan 30, 2025
Open
@brillout
Copy link
Member

The overall integration LGTM! Very exciting, vike-react-redux is a major integration 🚀

@brillout
Copy link
Member

Didn't look at the README, let me know when you want me to.

@brillout
Copy link
Member

How about we create an example for this examples/redux/? For important integrations I feel like it's worth it.

@brillout
Copy link
Member

Just pushed a polish commit. Intervention++ (most notably the missing type in import type { PageContext } and removing the superfluous ? which makes the code a bit slower to read). I wouldn't be that picky about polishing, but since we want users to eject extensions they might as well eject something pretty 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brillout brillout brillout left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phonzammi @brillout