Skip to content

Commit

Permalink
Merge pull request #18 from AurelienLourot/quality/minor-improvements
Browse files Browse the repository at this point in the history
Minor improvements
  • Loading branch information
magne4000 authored Sep 29, 2023
2 parents b838d5f + ea7fb0c commit 8334e43
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
Build `vike-solid`:

```bash
git clone [email protected]:magne4000/vike-solid
git clone [email protected]:vikejs/vike-solid
cd vike-solid/ && pnpm install
pnpm build
cd ../
Expand Down
2 changes: 1 addition & 1 deletion examples/basic/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Basic example of using `vike-solid`.

```bash
git clone [email protected]:magne4000/vike-solid
git clone [email protected]:vikejs/vike-solid
cd vike-solid/examples/basic/
pnpm install
pnpm run dev
Expand Down
2 changes: 1 addition & 1 deletion examples/ssr-spa/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Example of selecting SPA or SSR on a per-page basis. See
[SPA vs SSR (and more)](https://vike.dev/SPA-vs-SSR).

```bash
git clone [email protected]:magne4000/vike-solid
git clone [email protected]:vikejs/vike-solid
cd vike-solid/examples/ssr-spa/
npm install
npm run dev
Expand Down
5 changes: 2 additions & 3 deletions vike-solid/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@

# `vike-solid`

SolidJS integration for [Vike](https://github.com/vikejs/vike/issues/736) (using the
[V1 design](https://vike.dev/migration/v1-design)).
SolidJS integration for [Vike](https://github.com/vikejs/vike) (using the [V1 design](https://vike.dev/migration/v1-design)).

> [!NOTE]
> For integrations with React and Vue, see the other [`vike-*` packages](https://vike.dev/vike-packages).
See [examples/](https://github.com/magne4000/vike-solid/tree/main/examples).
See [examples/](https://github.com/vikejs/vike-solid/tree/main/examples).
2 changes: 1 addition & 1 deletion vike-solid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@
"bin": "./cli/entry.js",
"main": "dist/+config.js",
"types": "dist/renderer/+config.d.ts",
"repository": "github:magne4000/vike-solid",
"repository": "github:vikejs/vike-solid",
"license": "MIT"
}
2 changes: 1 addition & 1 deletion vike-solid/renderer/+config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { Config, ConfigEffect, PageContext } from "vike/types";
// We purposely define the ConfigVikeSolid interface in this file: that way we ensure it's always applied whenever the user `import vikeSolid from 'vike-solid'`
import type { Component } from "./types.js";

// Depending on the value of `config.meta.ssr`, set other config options' `env`
Expand Down Expand Up @@ -59,6 +58,7 @@ export default {
},
} satisfies Config;

// We purposely define the ConfigVikeSolid interface in this file: that way we ensure it's always applied whenever the user `import vikeSolid from 'vike-solid'`
declare global {
namespace VikePackages {
interface ConfigVikeSolid {
Expand Down

0 comments on commit 8334e43

Please sign in to comment.