-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESLint #128
Merged
Merged
Add ESLint #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtritto
force-pushed
the
eslint
branch
4 times, most recently
from
October 1, 2024 16:14
521e0d3
to
6753625
Compare
@rtritto Are you blocked by something to fix the last issues? |
@magne4000 can you try to fix the 3 warnings? |
NOTE: When biomejs/biome#2438 is closed, we should revert to biome only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ESLint with:
typescript-eslint
eslint-plugin-solid
FIX/TODO
/vike-solid/packages/vike-solid/helpers/clientOnly.tsx
24:37 warning This function should be passed to a tracked scope (like createEffect) or an event handler because it contains reactivity, or else changes will be ignored solid/reactivity
31:12 warning For proper analysis, a variable should be used to capture the result of this function call solid/reactivity
/vike-solid/packages/vike-solid/hooks/usePageContext.tsx
18:40 warning The reactive variable 'props.pageContext' should be used within JSX, a tracked scope (like createEffect), or inside an event handler function, or else changes will be ignored solid/reactivity
CI/workflows
pnpm lint