Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint #128

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Add ESLint #128

merged 9 commits into from
Oct 21, 2024

Conversation

rtritto
Copy link
Contributor

@rtritto rtritto commented Sep 26, 2024

Add ESLint with:

  • typescript-eslint
  • eslint-plugin-solid

FIX/TODO

  • /vike-solid/packages/vike-solid/helpers/clientOnly.tsx

    • 24:37 warning This function should be passed to a tracked scope (like createEffect) or an event handler because it contains reactivity, or else changes will be ignored solid/reactivity
    • 31:12 warning For proper analysis, a variable should be used to capture the result of this function call solid/reactivity
  • /vike-solid/packages/vike-solid/hooks/usePageContext.tsx

    • 18:40 warning The reactive variable 'props.pageContext' should be used within JSX, a tracked scope (like createEffect), or inside an event handler function, or else changes will be ignored solid/reactivity
  • CI/workflows

    • add pnpm lint

@rtritto rtritto force-pushed the eslint branch 4 times, most recently from 521e0d3 to 6753625 Compare October 1, 2024 16:14
@magne4000
Copy link
Member

@rtritto Are you blocked by something to fix the last issues?

@rtritto
Copy link
Contributor Author

rtritto commented Oct 19, 2024

@magne4000 can you try to fix the 3 warnings?
Then where pnpm lint should be integrated?

@magne4000
Copy link
Member

NOTE: When biomejs/biome#2438 is closed, we should revert to biome only.

@magne4000 magne4000 marked this pull request as ready for review October 21, 2024 09:09
@magne4000 magne4000 merged commit 664a685 into vikejs:main Oct 21, 2024
4 checks passed
@rtritto rtritto deleted the eslint branch October 21, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants