.upper() key in call to get_or_create
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 7, 2018 14:48
`get_or_create` IntegrityError bug fix See merge request mst/django-keyvaluestore!1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
KeyValueStore.save()you.upper()thekeyfield. This doesn't happen whenset_key_valuecallsKeyValueStore.objects.get_or_create(key=key, defaults={'value': value}). The standardmodels.Manager.get_or_createwill check for the non-.upper()field, return that it doesn't have that saved, and then call theKeyValueStore.save()method, which will then fail.Steps to repro:
call
set_key_value('cheese', 'cheesier')two times in a row.