StateField with abstract models #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty to state_info, which was breaking the tests
|
As is specified in django documentation sender should be a model class not an instance. This pull request fixes that too. |
| @@ -85,6 +85,14 @@ def name(si_self): | |||
| return getattr(self, field) | |||
|
|
|||
| @property | |||
| def initial(si_self): | |||
| """ | |||
| The description of the current state | |||
There was a problem hiding this comment.
Is this docstring correct? Don't you mean the initial state?
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes submitted in this pull request allow adding a StateField to an abstract model.
It behaves as expected:
_state_log_modeland other model methods are added only to concrete models.Also couple minor changes that allow using test_proj to run tests:
get_state_info().initialis referenced here, but not implementedtest_proj/settings.pyusesosbut doesn't import itAnd it also implements suggestion #56