Remove engines/node from package.json #89
Conversation
| @@ -59,9 +59,6 @@ | |||
| "peerDependencies": { | |||
| "ember-source": "^3.28.0 || ^4.0.0" | |||
| }, | |||
| "engines": { | |||
There was a problem hiding this comment.
Why are we removing these lines? Is there any documentation that you can link here?
There was a problem hiding this comment.
@villander this was discussed in embroider-build/addon-blueprint#15 and latest v2 addon blueprint does not provide engines.node
There was a problem hiding this comment.
Yes, but we still need to support V1 addons @SergeAstapov, does that make sense?
There was a problem hiding this comment.
@villander I don't get your concern.
This is addon is v2 addon, meaning it does not have any Node.js runtime.
v1 addons do require runtime hence any v1 should properly declare Node.js versions it supports.
|
Closing for inactivity. We can reopen it later if you want @SergeAstapov |
|
@villander I think I miss what kind of activity you expect on this PR as it's simple, straightforward and syncs addon setup with what already has been done in https://github.com/embroider-build/addon-blueprint. note there are no |
v2 addons are pure npm/JS packages with no Node.js runtime.
Hence, v2 addons do not depend on any specific version of Node.js
Without having this dormant yet explicitly listed on package.json, we can update Node.js version in CI and elsewhere without need to publish major version.