-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with latest addon blueprint and use decorator-transforms #94
Conversation
b60c1e2
to
ff961ef
Compare
side note: funnily enough, v5 scenarios pass only because repo uses yarn and yarn incorrectly handles peer dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple requested changes!
@SergeAstapov could you please describe what's size do you mean about the app? Are you talking about the testing-app?
ff961ef
to
9c79415
Compare
added link to PR description. RE: TL;DR |
9c79415
to
e11b5b1
Compare
We can merge this PR when CI get green again |
bc1c682
to
7731f14
Compare
7731f14
to
15a02cd
Compare
@villander this is refreshed with the latest blueprint as of now and CI is passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Sorry for the delay in merging it
v2 addon blueprint: https://github.com/embroider-build/addon-blueprint
Minor gain: using
decorator-transforms
reduced bundle size for the app.