Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 5.x #11164

Merged
merged 161 commits into from
Nov 24, 2024
Merged

Merge 5.x #11164

merged 161 commits into from
Nov 24, 2024

Conversation

danog
Copy link
Collaborator

@danog danog commented Nov 23, 2024

No description provided.

weirdan and others added 30 commits March 9, 2024 20:32
Resolved problem:
```
Psalm\Tests\AssertAnnotationTest::testAssertsAllongCallStaticMethodWork
Psalm\Exception\CodeException: LessSpecificReturnStatement
The type 'string' is more general than the declared return type 'non-empty-string' for returnNonEmpty
```
`TClosure` does not implement it at this point. It's intentional, to maintain the
separation between callables and closures that our code relies on.
Fixes all issues that emits a deprecation notice on PHP 8.4.

See:
 - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types)
 - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)
…non-default PHP binary

e.g. you run the tests with a php83 executable but your default php is PHP 7.4, it will suddenly change while running the tests leading to false positive errors
…lled-from-php-version

fix tests running with other than called PHP binary if called with a non-default PHP binary
…onfig

Explicitly set value in config to fix warning in tests
@danog danog added the release:internal The PR will be included in 'Internal changes' section of the release notes label Nov 23, 2024
@danog danog merged commit 8ae7e88 into master Nov 24, 2024
79 of 80 checks passed
@danog danog deleted the merge_master branch November 24, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.