-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 5.x #11164
Merged
Merged
Merge 5.x #11164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved problem: ``` Psalm\Tests\AssertAnnotationTest::testAssertsAllongCallStaticMethodWork Psalm\Exception\CodeException: LessSpecificReturnStatement The type 'string' is more general than the declared return type 'non-empty-string' for returnNonEmpty ```
`TClosure` does not implement it at this point. It's intentional, to maintain the separation between callables and closures that our code relies on.
…pertyNotSetInConstructor Fix #10786
Fixes all issues that emits a deprecation notice on PHP 8.4. See: - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types) - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)
…non-default PHP binary e.g. you run the tests with a php83 executable but your default php is PHP 7.4, it will suddenly change while running the tests leading to false positive errors
…lled-from-php-version fix tests running with other than called PHP binary if called with a non-default PHP binary
…onfig Explicitly set value in config to fix warning in tests
…s-as-subtypes-of-callable
…n-reports Fix JSON formatter crashes with invalid UTF in error messages
The break was introduced in #10483
danog
added
the
release:internal
The PR will be included in 'Internal changes' section of the release notes
label
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.