Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes : Missing Validation in Newsletter , SignUp Page, and Login Page | Text Justification | BackToTop Scrolling Issue... | Issue #444 #652

Closed
wants to merge 2 commits into from

Conversation

Shariq2003
Copy link
Contributor

@Shariq2003 Shariq2003 commented Oct 12, 2024

I have added the follwing :-

  1. Email Validation in Newsletter.
  2. Toast Alert Notification Newsletter.
  3. Smooth Scrolling for BackToTop Button.
  4. Login and SignUp page Email Validation.
  5. Login and SignUp page Taost Alerts for Success and Failure.
  6. I also clean the multiple-written code and the index.html file by removing the styling and adding it to the index.css file for better code understanding for new developers.
  7. Fix Dark/Light Mode.
bandicam.2024-10-13.02-39-22-664.mp4
bandicam.2024-10-13.02-51-12-000.mp4

Completed #444

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bobble-ai-rcmb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 9:17pm

Copy link

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@Shariq2003
Copy link
Contributor Author

@mansiruhil13 please review and merge

@vimistify
Copy link
Owner

there are conflicts, resolve. and some changes have done recently, so do changes accordingly

@vimistify
Copy link
Owner

and what's the issue no??

@Shariq2003
Copy link
Contributor Author

and what's the issue no??

I have mentioned 444

@Shariq2003
Copy link
Contributor Author

@mansiruhil13 mam, again the same issues are happening in the main branch
You have merged an another branch that causes the main branch down and also creates problems in other's branch like me 😥,

see the main branch deployment

bandicam.2024-10-14.22-21-04-773.mp4

@Shariq2003
Copy link
Contributor Author

@mansiruhil13 mam, please review the deployment beforehand of that particular branch, of which code u are going to merge.

@Shariq2003
Copy link
Contributor Author

Shariq2003 commented Oct 14, 2024

@mansiruhil13 my branch is all set i also shared the video of my branch, u can see that, and if want than set the main branch by my branch as upstream, I mean

git reset --hard 3ac86a2

or can also revert the merges that causes issues know.

By which the main branch will be set to stable mode,

@vimistify
Copy link
Owner

yes there are few changes done. assigned recently

@Shariq2003
Copy link
Contributor Author

yes there are few changes done. assigned recently

@mansiruhil13 if u merge the PRs by the Increasing order of issues number than the probability of conflict will be removed.
Maybe 😄

@vimistify
Copy link
Owner

yes there are few changes done. assigned recently

@mansiruhil13 if u merge the PRs by the Increasing order of issues number than the probability of conflict will be removed. Maybe 😄

ok

@vimistify
Copy link
Owner

but as of know already blunder is created

@Shariq2003
Copy link
Contributor Author

but as of know already blunder is created

No, you can solve them easily

@Shariq2003
Copy link
Contributor Author

@mansiruhil13 my branch is all set i also shared the video of my branch, u can see that, and if want than set the main branch by my branch as upstream, I mean

git reset --hard 3ac86a2

or can also revert the merges that causes issues know.

By which the main branch will be set to stable mode,

.

@vimistify
Copy link
Owner

but some of them assigned recently for improvements.

@Shariq2003
Copy link
Contributor Author

Shariq2003 commented Oct 14, 2024

but some of them assigned recently for improvements.

So @mansiruhil13 mam, what should I do know, as the main branch contains conflicts

Like my PR is ready but causes happened by main branch

@vimistify
Copy link
Owner

vimistify commented Oct 14, 2024

but some of them assigned recently for improvements.

So @mansiruhil13 mam, what should I do know, as the main branch contains conflicts

Like my PR is ready but causes happened by main branch

in your branch, toggle and translator there? *although assigned recently

@vimistify
Copy link
Owner

vimistify commented Oct 14, 2024

Screenshot 2024-10-14 223708
and conflicts also there in this pr. resolve

@vimistify vimistify closed this Oct 14, 2024
Copy link

🚀 Thank you for your contribution! This pull request has been closed. If you have any questions or need further assistance, feel free to reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants