Skip to content

Commit

Permalink
fix(maven): rework module names and plugins
Browse files Browse the repository at this point in the history
* remove `fpi-framework` prefix for each module
* specify `groupId` for each plugin
* add `maven-deploy-plugin`
  • Loading branch information
vincejv committed Nov 14, 2022
1 parent cbd9257 commit 744d09a
Show file tree
Hide file tree
Showing 99 changed files with 1,009 additions and 999 deletions.
94 changes: 47 additions & 47 deletions fpi-framework-bom/.gitignore → bom/.gitignore
Original file line number Diff line number Diff line change
@@ -1,47 +1,47 @@
#Maven
target/
pom.xml.tag
pom.xml.releaseBackup
pom.xml.versionsBackup
release.properties
.flattened-pom.xml

# Eclipse
.project
.classpath
.settings/
bin/

# IntelliJ
.idea
*.ipr
*.iml
*.iws

# NetBeans
nb-configuration.xml

# Visual Studio Code
.vscode
.factorypath

# OSX
.DS_Store

# Vim
*.swp
*.swo

# patch
*.orig
*.rej

# Local environment
.env
/app.yaml

# Prod Keys
**/*application-prod.yml

# Versioning plugin
.git-versioned-pom.xml
#Maven
target/
pom.xml.tag
pom.xml.releaseBackup
pom.xml.versionsBackup
release.properties
.flattened-pom.xml

# Eclipse
.project
.classpath
.settings/
bin/

# IntelliJ
.idea
*.ipr
*.iml
*.iws

# NetBeans
nb-configuration.xml

# Visual Studio Code
.vscode
.factorypath

# OSX
.DS_Store

# Vim
*.swp
*.swo

# patch
*.orig
*.rej

# Local environment
.env
/app.yaml

# Prod Keys
**/*application-prod.yml

# Versioning plugin
.git-versioned-pom.xml
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
10 changes: 10 additions & 0 deletions fpi-framework-bom/pom.xml → bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
<org.mapstruct.version>1.5.3.Final</org.mapstruct.version>
<skipITs>true</skipITs>
<surefire-plugin.version>3.0.0-M7</surefire-plugin.version>
<deploy-plugin.version>3.0.0</deploy-plugin.version>
<lombok-mapstruct-binding.version>0.2.0</lombok-mapstruct-binding.version>
<org.projectlombok.version>1.18.24</org.projectlombok.version>
<apache.commons-lang3.version>3.12.0</apache.commons-lang3.version>
Expand Down Expand Up @@ -168,6 +169,7 @@
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>${compiler-plugin.version}</version>
<configuration>
Expand Down Expand Up @@ -209,6 +211,7 @@
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${surefire-plugin.version}</version>
<configuration>
Expand All @@ -220,6 +223,7 @@
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<version>${surefire-plugin.version}</version>
<executions>
Expand Down Expand Up @@ -258,6 +262,12 @@
</executions>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-deploy-plugin</artifactId>
<version>${deploy-plugin.version}</version>
</plugin>

</plugins>
</pluginManagement>
</build>
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion fpi-framework-core/pom.xml → core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<groupId>com.abavilla</groupId>
<artifactId>fpi-framework-bom</artifactId>
<version>0</version> <!-- version will be autogenerated through Git SHA -->
<relativePath>../fpi-framework-bom/pom.xml</relativePath>
<relativePath>../bom/pom.xml</relativePath>
</parent>

<properties>
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@
<packaging>pom</packaging>

<modules>
<module>fpi-framework-bom</module>
<module>fpi-framework-core</module>
<module>fpi-framework-pom</module>
<module>bom</module>
<module>core</module>
<module>pom</module>
</modules>

<properties>
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
maven-wrapper.jar
maven-wrapper.jar
Loading

0 comments on commit 744d09a

Please sign in to comment.