Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firmware version sensors for all devices #168

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

vincentwolsink
Copy link
Owner

Also reworked the classes inheritance a bit. To make it a bit more logical (to me at least).

@vincentwolsink vincentwolsink linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Oct 28, 2024

@vincentwolsink
Copy link
Owner Author

I am a bit in doubt if a sensor on each device is very useful. Or we should just go with one sensor for just the Envoy itself.

@mnederlof
Copy link
Collaborator

i'd do them all, as the firmware version of your inverter might be updates as well, when you create a support request for it with enphase

@vincentwolsink vincentwolsink merged commit e019ac9 into main Oct 28, 2024
5 checks passed
@vincentwolsink vincentwolsink deleted the firmware_sensors branch October 28, 2024 17:07
@M66B
Copy link

M66B commented Oct 28, 2024

@vincentwolsink thanks for this rather fast and thorough implementation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entities for firmware version
3 participants