New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-substantive changes per recommendations #24

Open

dathbe wants to merge 2 commits into vincep5:master from dathbe:master

dathbe commented Mar 29, 2024

Non-substantive changes as recommended here https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/blob/main/result.md#MMM-MyStandings-by-vincep5

They also recommend:

Adding a license (both a LICENSE file and in package.json)
Replacing require(request) in node_helper.js with the built-in fetch function
Adding ESLint configuration

I'm not able to the 1st or 3rd, but I could maybe look into the 2nd when I have more time.

dathbe added 2 commits

March 28, 2024 17:23


          Update package.json

a0c815a

Add additional fields


          Update node_helper.js

ffccb37

magic mirror > magicmirror2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet