Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix sign command options & show global options in subcommand help #4

Merged
merged 4 commits into from
Oct 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/bin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ program
'the API URL prefix, https://addons.mozilla.org if unspecified',
)
.option('--addon-id <addonId>', 'addon UUID which can be found in AMO')
.configureHelp({ showGlobalOptions: true })
.version(pkg.packageJson.version);

program
Expand Down Expand Up @@ -60,7 +61,11 @@ This command could be run multiple times to check the status, and the version wi
)
.option('--output <output>', 'the file path to save the signed XPI file')
.action(
wrapError(async (options) => {
wrapError(async (_, command) => {
const options = {
...loadFromEnv(),
...command.optsWithGlobals(),
};
verifyKeys(options, ['apiKey', 'apiSecret', 'addonId', 'addonVersion']);
const downloadedFile = await signAddon({
apiKey: options.apiKey as string,
Expand Down