Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error reporting #253

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Fix error reporting #253

merged 3 commits into from
Feb 26, 2024

Conversation

fpoli
Copy link
Member

@fpoli fpoli commented Feb 22, 2024

Fix the rendering of error messages reported either on an absolute path or in a different crate within the same workspace. This change adds a call to cargo metadata before each cargo-prusti.

Fixes #218, #252

@fpoli fpoli enabled auto-merge February 22, 2024 15:48
@fpoli fpoli disabled auto-merge February 22, 2024 15:48
@fpoli fpoli changed the title Fix workspaces Fix error reporting Feb 22, 2024
@fpoli fpoli enabled auto-merge February 22, 2024 15:49
@fpoli fpoli self-assigned this Feb 22, 2024
@fpoli fpoli disabled auto-merge February 22, 2024 15:51
@fpoli fpoli force-pushed the fix-workspaces branch 8 times, most recently from 6230210 to a8d7d4a Compare February 23, 2024 10:08
@fpoli
Copy link
Member Author

fpoli commented Feb 23, 2024

Now it's ready. Could someone from @viperproject/prusti-dev review this?

@fpoli fpoli requested review from prusti-devs and a team and removed request for JonasAlaif and prusti-devs February 26, 2024 11:27
Copy link

@vakaras vakaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I am not familiar with the codebase…

@fpoli fpoli merged commit 36a91a5 into master Feb 26, 2024
6 checks passed
@fpoli fpoli deleted the fix-workspaces branch February 26, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Error Reporting when Verifying Project containing Cargo Workspace
2 participants