Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Isabelle2024 container for CI #5

Closed
wants to merge 9 commits into from
Closed

Conversation

gauravpartha
Copy link
Contributor

No description provided.

@gauravpartha
Copy link
Contributor Author

Closing this PR since I prefer having an approach that is independent from a specific container with Isabelle installed. One reason is that the official Isabelle container makarius/isabelle:Isabelle2024 does not include git, which the checkout action seems to require if submodules are present. Installing git on every run is an option (as done in this PR), but I prefer a solution, which instead works on a container with git already installed, since I want a solution that is easily reusable across Isabelle repositories without such additional dependency installing. Another option would be to set up our own container installing Isabelle and git, but then we would have to update that container for every new Isabelle version (not much work, but still extra work).

Instead I merged pull request #6, which uses a separate GitHub action to download and cache Isabelle (the Isabelle version can be provided via a parameter to this action).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant