Update Response struct to follow RFC 7516
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to RFC 7516, if AEAD is used in JWE, `aad` must be included to JSON serialization of the JWE. See https://datatracker.ietf.org/doc/html/rfc7516#section-7.2.1 Signed-off-by: Xynnn007 <[email protected]>
The struct of the ProtectedHeader is actually well defined in RFC7519, the changing from string to a struct would do help to serialization and deserialization. See https://datatracker.ietf.org/doc/html/rfc7516 Signed-off-by: Xynnn007 <[email protected]>
Xynnn007
requested review from
crobinso,
slp,
tylerfanelli and
sameo
as code owners
tylerfanelli
approved these changes
Nov 27, 2024
Yes. I will update this in confidential-containers/trustee#597 then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original KBS Protocol's
Responsefollows RFC7519's JWE definition. Now it is lacked ofaadfield for AEAD. Also, this patch adds the definition forProtectedHeaderdue to the RFC.