Apply RFC7516 Standard to Response #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xynnn007
requested review from
crobinso,
slp,
tylerfanelli and
sameo
as code owners
tylerfanelli
requested changes
Dec 2, 2024
Xynnn007
force-pushed
the
fix-pub
branch
3 times, most recently
from
b8d56d9 to
e19170d
Compare
|
@tylerfanelli Just took a rebase to follow #49, #50, #51 |
|
@Xynnn007 thanks, please push the rebased branch again so the tests can re-run. |
This patch is a fix up to previous commits to update the Response struct to follow RFC7516. The work included in the commit 1. Make both serialization and deserialization of `ProtectedHeader` use base64-url-nopadding encoding. This means that the whole ProtectedHeader will be serialized into a base64 string, rather than a struct. 2. Make `encrypted_key`, `aad`, `iv`, `ciphertext`, `tag` to base64-url-nopadding encoded string when serializing. 3. Automatical deseralization logic when parsing Response from a flattened JSON JWE Serialization. Signed-off-by: Xynnn007 <[email protected]>
Due to RFC7516, aad used in AEAD is derived from ProtectedHeader. This function does this. Signed-off-by: Xynnn007 <[email protected]>
This commit adds error handling for the crate using thiserror crate. Also, based on the error handling, making serialization of `AAD` eleganttly be handled with result mechanism. Signed-off-by: Xynnn007 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a fix up to previous commits to update the Response struct to follow RFC7516.
The work included in the commit
ProtectedHeaderuse base64-url-nopadding encoding. This means that the whole ProtectedHeader will be serialized into a base64 string, rather than a struct.encrypted_key,aad,iv,ciphertext,tagto base64-url-nopadding encoded string when serializing.generate_aad()function toProtectedHeaderClose #47