Response: fix some bugs of Response struct #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous commits we did a duplicated base64 encoding and decoding when serializing/deserializing the AAD field. Signed-off-by: Xynnn007 <[email protected]>
Xynnn007
changed the title
For JWE using EC or ECX, the ephemeral asymmetric public key should be included in the ProtectedHeader. It will be a nested structure rather than flatten fields. Signed-off-by: Xynnn007 <[email protected]>
Xynnn007
force-pushed
the
fix-aad-serialization
branch
from
e95eb8d to
f56c565
Compare
|
succeeded testing locally with confidential-containers/trustee#597 for JWE compability and confidential-containers/guest-components#820 for kbs-client/server resource access |
tylerfanelli
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProtectedHeaderto allow nested structues forECsuites.