Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[packaging] Fixup buildall.bat #1209

Closed
wants to merge 1 commit into from
Closed

[packaging] Fixup buildall.bat #1209

wants to merge 1 commit into from

Conversation

benyamin-codez
Copy link
Contributor

Made directory creation conditional (if not exist)
Removes reference to non-existent file COPYING

@benyamin-codez
[packaging] Fixup buildall.bat
c902a2d 
Made directory creation conditional (if not exist)
Removes reference to non-existent file COPYING

Signed-off-by: benyamin-codez <[email protected]>
@kostyanf14
Copy link
Member

@YanVugenfirer Do we still need this folder for anything?

@benyamin-codez benyamin-codez mentioned this pull request Dec 5, 2024
Closed
@kostyanf14
Copy link
Member

@vrozenfe Do we still need this folder for anything?

@benyamin-codez
Copy link
Contributor Author

@YanVugenfirer @vrozenfe @kostyanf14

This basically creates the old unattended floppy disk style OEM TXTSETUP driver disk tree, in this case for viostor...

If you think it worthwhile, I'm happy to add a commit to delete it here...
...and one each for PRs #1211 and #1212 to remove it there also... 8^d
Let me know.

@vrozenfe
Copy link
Collaborator

vrozenfe commented Dec 9, 2024

@vrozenfe Do we still need this folder for anything?

Starting with RHEL-8, we no longer provide VFD images.
The main reason, as far as I remember, is that RHEL's QEMU
doesn't support floppy disk controllers anymore.
But who knows what might happen in the future?

Also, if we ever do a full cleanup, we could remove all OEM
and VFD related stuff from the virtio-win and packaging
repositories.

Cheers,
Vadim.

@YanVugenfirer
Copy link
Collaborator

Also, if we ever do a full cleanup, we could remove all OEM
and VFD related stuff from the virtio-win and packaging
repositories.

OK, so let's remove all VFD related stuff @benyamin-codez

@benyamin-codez
Copy link
Contributor Author

@YanVugenfirer @vrozenfe

Also, if we ever do a full cleanup, we could remove all OEM
and VFD related stuff from the virtio-win and packaging
repositories.

OK, so let's remove all VFD related stuff

So do you wish me to redo this PR to delete the [packaging] folder and associated artefacts in clean and build...?

Will this break anything else in virtio-win, including the packaging repos...?
Are there any other OEM or VFD related stuff that need to be removed also...?
I'm not familiar enough with the rest of the tree or the packaging repos to even know where to start...

@kostyanf14
Copy link
Member

@benyamin-codez

So do you wish me to redo this PR to delete the [packaging] folder and associated artefacts in clean and build...?

Yes

Will this break anything else in virtio-win, including the packaging repos...?

It shouldn't break

benyamin-codez added a commit to benyamin-codez/kvm-guest-drivers-windows that referenced this pull request Dec 18, 2024
@benyamin-codez
[packaging] Remove packaging folder
b9c8a69 
1. Remove the packaging folder.

Refer to PR virtio-win#1209 for commentary.

Signed-off-by: benyamin-codez <[email protected]>
@benyamin-codez benyamin-codez mentioned this pull request Dec 18, 2024
Open
benyamin-codez added a commit to benyamin-codez/kvm-guest-drivers-windows that referenced this pull request Dec 18, 2024
@benyamin-codez
[build] Scrub the cleaners
85270fb 
Addendum to 52d23db, 3bc554e and 933b732.

1. Removed packaging folder from root\clean.bat per PR virtio-win#1209.

Signed-off-by: benyamin-codez <[email protected]>
benyamin-codez added a commit to benyamin-codez/kvm-guest-drivers-windows that referenced this pull request Dec 18, 2024
@benyamin-codez
[build] Fix and extend build scripting
a92c45c 
Addendum to da96c89 and 74f5391.

1. Removed packaging folder from root\buildAll.bat per PR virtio-win#1209.

Signed-off-by: benyamin-codez <[email protected]>
@benyamin-codez
Copy link
Contributor Author

Changes made to delete:

  1. Folder - New PR #1224
  2. Reference in root\clean.bat - Added to PR #1211
  3. Reference in root\buildAll.bat - Added to PR #1212

This was referenced Dec 18, 2024
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanVugenfirer YanVugenfirer YanVugenfirer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benyamin-codez @kostyanf14 @vrozenfe @YanVugenfirer