feat: [Pallet Pass] Configuration extensions #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandres95
changed the title
…ore enabling feeless execution of `authenticate`
…peating ourselves
olanod
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request implements two complementary extensions, necessary to make
pallet-passfunction correctly.SignedExtensionthat helps charging the actualAccountIdfor the pass user.authenticatecall to make it be free if the authentication attempt is valid (i.e. the device resolves to anAccountIdand such account exists).This is because authentication should be a free service (I mean, how would you authenticate on a system if you can't pay fees otherwise?)