fix(pydeck-carto): Use local isPureObject #8880
Merged
+31
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the latest version of pydeck-carto in a Python notebook environment, a function imported from
@loaders.gl/core
is not available, and throws an error when calling requestWithParameters:There's some nuance in how the Python packages load dependencies from CDNs, which could benefit from a closer look, but in the meantime ... the function is very short, and maybe importing it from
@loaders.gl/core
is unnecessary. To resolve the bug, I've copiedisObject
andisPureObject
into the CARTO module, both are one-liners.Publishing a patch release of
@deck.gl/carto
will be enough to fix the bug — pydeck-carto does not require an update.Background
Change List
isObject
andisPureObject
from@loaders.gl/core