Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack) no longer need to remove 'fs' import at compile-time #168

Merged
merged 3 commits into from
Oct 19, 2021

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Sep 30, 2021

For #158.
Todo

@chrisgervang chrisgervang changed the title remove(webpack) no longer need to remove 'fs' import at compile-time fix(webpack) no longer need to remove 'fs' import at compile-time Sep 30, 2021
@coveralls
Copy link

coveralls commented Sep 30, 2021

Pull Request Test Coverage Report for Build 1292560605

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.511%

Totals Coverage Status
Change from base Build 1292514478: 0.0%
Covered Lines: 217
Relevant Lines: 709

💛 - Coveralls

@chrisgervang chrisgervang added this to the 1.4 milestone Oct 15, 2021
@chrisgervang chrisgervang marked this pull request as ready for review October 19, 2021 18:03
@chrisgervang chrisgervang merged commit 046327a into master Oct 19, 2021
@chrisgervang chrisgervang deleted the chr/update-webm-writer branch October 19, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants