fix(parquet): More robust Buffer polyfill export (#3105)

visgl · Sep 30, 2024 · 5f4973a · 5f4973a
1 parent d52f0e4
commit 5f4973a
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 13 deletions.
diff --git a/modules/compression/src/lib/compression.ts b/modules/compression/src/lib/compression.ts
@@ -3,8 +3,7 @@
 // Copyright (c) vis.gl contributors
 
 // Compression interface
-import {concatenateArrayBuffersAsync} from '@loaders.gl/loader-utils';
-import {registerJSModules} from '@loaders.gl/loader-utils';
+import {concatenateArrayBuffersAsync, registerJSModules} from '@loaders.gl/loader-utils';
 
 /** Compression options */
 export type CompressionOptions = {

diff --git a/modules/compression/src/lib/lz4-compression.ts b/modules/compression/src/lib/lz4-compression.ts
@@ -26,8 +26,7 @@
 /* eslint-disable max-statements */
 
 // LZ4
-import {toArrayBuffer} from '@loaders.gl/loader-utils';
-import {registerJSModules, getJSModule} from '@loaders.gl/loader-utils';
+import {toArrayBuffer, registerJSModules, getJSModule} from '@loaders.gl/loader-utils';
 import type {CompressionOptions} from './compression';
 import {Compression} from './compression';
 

diff --git a/modules/images/test/lib/category-api/parsed-image-api.spec.ts b/modules/images/test/lib/category-api/parsed-image-api.spec.ts
@@ -1,9 +1,9 @@
 import test from 'tape-promise/tape';
 import {load} from '@loaders.gl/core';
-import {ImageLoader, ImageType} from '@loaders.gl/images';
-
-// PARSED IMAGE API
 import {
+  ImageLoader,
+  ImageType,
+  // PARSED IMAGE API
   getDefaultImageType,
   isImageTypeSupported,
   isImage,

diff --git a/modules/mvt/src/lib/vector-tile/vector-tile-feature.ts b/modules/mvt/src/lib/vector-tile/vector-tile-feature.ts
@@ -3,8 +3,13 @@
 // Copyright vis.gl contributors
 
 // This code is forked from https://github.com/mapbox/vector-tile-js under BSD 3-clause license.
-import {Feature} from '@loaders.gl/schema';
-import {FlatFeature, FlatIndexedGeometry, GeojsonGeometryInfo} from '@loaders.gl/schema';
+
+import type {
+  Feature,
+  FlatFeature,
+  FlatIndexedGeometry,
+  GeojsonGeometryInfo
+} from '@loaders.gl/schema';
 import Protobuf from 'pbf';
 import {
   classifyRings,

diff --git a/modules/parquet/src/parquet-loader.ts b/modules/parquet/src/parquet-loader.ts
@@ -20,7 +20,11 @@ import {
   parseParquetFileInColumnarBatches
 } from './lib/parsers/parse-parquet-to-columns';
 
-export {Buffer} from './polyfills/buffer/install-buffer-polyfill';
+// Note: The Buffer polyfill is quite fragile
+// For some reason, just exporting directly fails with some bundlers
+// export {Buffer} from './polyfills/buffer/install-buffer-polyfill';
+import {Buffer} from './polyfills/buffer/install-buffer-polyfill';
+export {Buffer};
 
 // __VERSION__ is injected by babel-plugin-version-inline
 // @ts-ignore TS2304: Cannot find name '__VERSION__'.

diff --git a/modules/tile-converter/src/i3s-converter/helpers/batch-ids-extensions.ts b/modules/tile-converter/src/i3s-converter/helpers/batch-ids-extensions.ts
@@ -1,18 +1,19 @@
 /* eslint-disable camelcase */
-import {GLTFAccessorPostprocessed, GLTFMeshPrimitivePostprocessed} from '@loaders.gl/gltf';
 import type {NumericArray} from '@loaders.gl/loader-utils';
 import type {
+  GLTFAccessorPostprocessed,
+  GLTFMeshPrimitivePostprocessed,
   GLTF_EXT_feature_metadata_FeatureIdTexture,
   GLTF_EXT_feature_metadata_GLTF,
   GLTF_EXT_feature_metadata_Primitive,
   GLTF_EXT_mesh_features
 } from '@loaders.gl/gltf';
+import {EXT_MESH_FEATURES, EXT_FEATURE_METADATA} from '@loaders.gl/gltf';
+import {Tiles3DTileContent} from '@loaders.gl/3d-tiles';
 
 import {TypedArray} from '@math.gl/core';
 import {TextureImageProperties} from '../types';
 import {emod} from '@loaders.gl/math';
-import {EXT_MESH_FEATURES, EXT_FEATURE_METADATA} from '@loaders.gl/gltf';
-import {Tiles3DTileContent} from '@loaders.gl/3d-tiles';
 
 /**
  * Get featureTexture by a metadata class.