Fix segv with PyTable.C #17396
Merged
Fix segv with PyTable.C #17396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check for size of results vector before referencing elements.
cyrush
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
This looks like good protection, but maybe these are debug statements that we should remove? @Laganellac what are you thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #17381
Added check for size of results vector before referencing elements.
Type of change
How Has This Been Tested?
I ran the flatten.py query test on Windows and the cli didn't crash.
Checklist:
- [ ] I have commented my code where applicable.- [ ] I have updated the release notes.- [ ] I have made corresponding changes to the documentation.- [ ] I have added debugging support to my changes.- [ ] I have added tests that prove my fix is effective or that my feature works.- [ ] I have confirmed new and existing unit tests pass locally with my changes.- [ ] I have added new baselines for any new tests to the repo.- [ ] I have NOT made any changes to protocol or public interfaces in an RC branch.