Support Playwright 1.39

CHANGELOG.md

@@ -4,6 +4,7 @@
 * i18n: Generate scenario outlines correctly [#60](https://github.com/vitalets/playwright-bdd/issues/60).
 * Check for duplicate fixture names [#52](https://github.com/vitalets/playwright-bdd/issues/52)
 * Fix flushing logs for several projects [#59](https://github.com/vitalets/playwright-bdd/issues/59)
+* Support Playwright `1.39`.
 
 ## 5.3.0
 * Add support for Playwright `1.38`.

src/playwright/testTypeImpl.ts

@@ -26,6 +26,25 @@ export function getTestImpl(test: TestTypeCommon) {
   return test[testTypeSymbol] as any;
 }
 
+/**
+ * Run step with location pointing to Given, When, Then call.
+ */
+// eslint-disable-next-line max-params
+export async function runStepWithCustomLocation(
+  test: TestTypeCommon,
+  stepText: string,
+  location: Location,
+  body: () => unknown,
+) {
+  const testInfo = test.info();
+
+  // See: https://github.com/microsoft/playwright/blob/main/packages/playwright/src/common/testType.ts#L221
+  // @ts-expect-error _runAsStep is hidden from public
+  return testInfo._runAsStep({ category: 'test.step', title: stepText, location }, async () => {
+    return await body();
+  });
+}
+
 /**
  * Returns true if all fixtures of parent test found in child test.
  */

src/run/bddWorld.ts

@@ -4,7 +4,7 @@ import { ISupportCodeLibrary } from '@cucumber/cucumber/lib/support_code_library
 import { PickleStep } from '@cucumber/messages';
 import { findStepDefinition } from '../cucumber/loadSteps';
 import { getLocationInFile } from '../playwright/getLocationInFile';
-import { getTestImpl } from '../playwright/testTypeImpl';
+import { runStepWithCustomLocation } from '../playwright/testTypeImpl';
 import { TestTypeCommon } from '../playwright/types';
 import { getStepCode } from '../stepDefinitions/defineStep';
 
@@ -50,7 +50,8 @@ export class BddWorld<ParametersType = any> extends CucumberWorld<ParametersType
     this.customFixtures = customFixtures;
     const code = getStepCode(stepDefinition);
 
-    // get location of step call in generated test file
+    // Get location of step call in generated test file.
+    // This call must be exactly here to have correct call stack.
     const location = getLocationInFile(this.test.info().file);
 
     const { parameters } = await stepDefinition.getInvocationParameters({
@@ -59,9 +60,10 @@ export class BddWorld<ParametersType = any> extends CucumberWorld<ParametersType
       world: this,
     });
 
-    const res = await getTestImpl(this.test)._step(location, text, () =>
+    const res = await runStepWithCustomLocation(this.test, text, location, () =>
       code.apply(this, parameters),
     );
+
     delete this.customFixtures;
 
     return res;