Add in FastAPI as a benchmark #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensenbox
commented
Mar 14, 2023
jensenbox
commented
- Introduce FastAPI as a new benchmark
- Add a new gunicorn benchmark for ninja
- Remove graph as it becomes stale too easily
- Sort imports
- Remove unused code from run_test.py
- Intentionally unfreeze the requirements.txt - this is to allow for the benchmark to run with the latest versions.
* Introduce FastAPI as a new benchmark * Add a new gunicorn benchmark for ninja * Remove graph as it becomes stale too easily * Sort imports * Remove unused code from run_test.py * Intentionally unfreeze the requirements.txt - this is to allow for the benchmark to run with the latest versions.
|
@vitalik it'd be nice to update the benchmark at some point no? 2020 is a very long time ago and a lot has happened since then |
|
sure, but current focus is to adapt to pydantic2 and then will start benchmarking work |
|
You're the best! Long live django-ninja |
|
I could turn this into a GitHub Action workflow that could be run from time to time - The performance numbers are purely relative anyway right? Benchmarks are always relative - comparing one framework to another on the same hardware is the goal normally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.