-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A couple endtoend
cluster tests enhancement
#17247
Merged
deepthi
merged 2 commits into
vitessio:main
from
planetscale:endtoend-vtctldclient-quiet
Nov 25, 2024
Merged
A couple endtoend
cluster tests enhancement
#17247
deepthi
merged 2 commits into
vitessio:main
from
planetscale:endtoend-vtctldclient-quiet
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 18, 2024
shlomi-noach
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Nov 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17247 +/- ##
==========================================
+ Coverage 67.39% 67.40% +0.01%
==========================================
Files 1570 1570
Lines 252917 252917
==========================================
+ Hits 170446 170490 +44
+ Misses 82471 82427 -44 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
shlomi-noach
removed
the
NeedsIssue
A linked issue is missing for this Pull Request
label
Nov 18, 2024
dbussink
changed the title
A couple
A couple Nov 19, 2024
endtond
cluster tests enhancementendtoend
cluster tests enhancement
frouioui
reviewed
Nov 19, 2024
rohit-nayak-ps
approved these changes
Nov 25, 2024
deepthi
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two enhancements in
go/test/endtoend/cluster
:VtctldClientProcess
supportsQuiet
mode, where it does not log the command line invocation to standard output. TheQuiet
field is not thread safe.This will be useful to reduce log clutter. I especially intend to use it to reduce
CheckThrottler
logs.VttabletProcess
supportsMultiQueryTablet()
, complementingMultiQueryTabletWithDB()
. This can be used to issue non-DB specific multi-query SQL from external source.Related Issue(s)
No issue for this PR.
Checklist
Deployment Notes