Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui,browser): load panel sizes from storage on initial load #7265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

userquin
Copy link
Member

@userquin userquin commented Jan 16, 2025

Description

The problem was about restoring the sizes using @ready event in the root split pane: there was some race condition between local storage and the event handling.

There is also similar problem with the Hide/Show Right Panel button in browser mode when hidding the right panel and initial load or page refresh: showing Hide Right Panel button instead Show Right Panel.

This PR also includes:

  • use resize observer in Explorer.vue to change the filter based on its width instead on main and panels sizes: on initial load or page refresh sometimes the filter with wrong grid columns (the filter will not change while resizing until resized).
  • increase the navigator percentage to 15% in BrowserIFrame.vue to show the Show Navigation Panel button (browser mode).

closes #6678
supersedes #6679

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@userquin userquin requested a review from sheremet-va January 16, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI splitpanes sizes are no longer persisted to local storage
1 participant