Fix articles per year issue when there is no data

vitorfs · Mar 11, 2020 · 437c539 · 437c539
1 parent f0135f8
commit 437c539
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/parsifal/reviews/conducting/views.py b/parsifal/reviews/conducting/views.py
@@ -876,11 +876,14 @@ def articles_selection_chart(request):
 
 def articles_per_year(request):
     review_id = request.GET['review-id']
-    review = Review.objects.get(pk=review_id)
+    review = get_object_or_404(Review, pk=review_id)
     final_articles = review.get_final_selection_articles().values('year').annotate(count=Count('year')).order_by('-year')
     articles = []
     for article in final_articles:
-        articles.append(article['year'] + ':' + str(article['count']))
+        try:
+            articles.append(article['year'] + ':' + str(article['count']))
+        except Exception:
+            pass
     return HttpResponse(','.join(articles))
 
 @author_required