Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New External API Extraction Feature #379

Draft
wants to merge 65 commits into
base: main
Choose a base branch
from

Conversation

silvanheller
Copy link
Member

@silvanheller silvanheller commented May 15, 2023

This Draft PR contains work towards #370 and additionally has some cleanup for feature-related code.

For testing purposes, there is a file named external_extraction.json which showcases the usage. This will be removed before merging.

new features

  • new Feature ExternalAPI with configurable entity name, API endpoint, feature type, vector length, correspondence incl. parameters, distance, model.
    • currently expects endpoints to offer two things: extract/image which can handle base64-encoded pngs, and extract/text, which handles text. These enpoints can return a single vector or string which is then used for retrieval or persisted.

cleanup

  • unifying naming w.r.t entity / table. Now everything is named entity which is what we mostly use (esp. in Cottontail)

@faberf faberf force-pushed the external-api-extraction branch from d29efca to 54c6fdf Compare June 8, 2023 15:21
@@ -414,6 +414,7 @@ private float[] embedModel(IModel model) throws IOException, InterruptedExceptio

private float[] embedVideo(List<MultiImage> frames) throws IOException, InterruptedException {
var images = frames.stream().map(image -> image.getBufferedImage()).collect(Collectors.toList());
images = images.stream().map(img -> new BufferedImage(img.getWidth(), img.getHeight(), BufferedImage.TYPE_INT_RGB)).collect(Collectors.toList());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are overwriting the previously generated images with empty images here, that is almost certainly not what you want.

lucaro and others added 24 commits October 8, 2023 16:42
# Conflicts:
#	cineast-core/src/main/java/org/vitrivr/cineast/core/db/cottontaildb/CottontailSelector.java
#	cineast-runtime/src/main/resources/log4j2.xml
Start python server on startup in an conda environment
* Added light classes

* Added lighting functionality

* Added conditional lighting

* Set options to lighting

* changed media m3d

* 3d settings

* settings changed
depth == 0  is the parent folder,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants