-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New External API Extraction Feature #379
Draft
silvanheller
wants to merge
65
commits into
main
Choose a base branch
from
external-api-extraction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faberf
force-pushed
the
external-api-extraction
branch
from
June 8, 2023 15:21
d29efca
to
54c6fdf
Compare
- unifying naming w.r.t entity / table
faberf
force-pushed
the
external-api-extraction
branch
from
June 8, 2023 16:29
54c6fdf
to
7d27038
Compare
refactored the dataurl and fileextension to use getters
- unifying naming w.r.t entity / table
lucaro
reviewed
Sep 11, 2023
@@ -414,6 +414,7 @@ private float[] embedModel(IModel model) throws IOException, InterruptedExceptio | |||
|
|||
private float[] embedVideo(List<MultiImage> frames) throws IOException, InterruptedException { | |||
var images = frames.stream().map(image -> image.getBufferedImage()).collect(Collectors.toList()); | |||
images = images.stream().map(img -> new BufferedImage(img.getWidth(), img.getHeight(), BufferedImage.TYPE_INT_RGB)).collect(Collectors.toList()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are overwriting the previously generated images with empty images here, that is almost certainly not what you want.
# Conflicts: # cineast-core/src/main/java/org/vitrivr/cineast/core/db/cottontaildb/CottontailSelector.java # cineast-runtime/src/main/resources/log4j2.xml
Start python server on startup in an conda environment
* Added light classes * Added lighting functionality * Added conditional lighting * Set options to lighting * changed media m3d * 3d settings * settings changed
depth == 0 is the parent folder,
…al library stucks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Draft PR contains work towards #370 and additionally has some cleanup for feature-related code.
For testing purposes, there is a file named
external_extraction.json
which showcases the usage. This will be removed before merging.new features
ExternalAPI
with configurable entity name, API endpoint, feature type, vector length, correspondence incl. parameters, distance, model.extract/image
which can handle base64-encoded pngs, andextract/text
, which handles text. These enpoints can return a single vector or string which is then used for retrieval or persisted.cleanup
entity
which is what we mostly use (esp. in Cottontail)