Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute not working with keybones. #1138

Closed
akelch opened this issue Apr 10, 2024 · 4 comments · Fixed by #1145
Closed

compute not working with keybones. #1138

akelch opened this issue Apr 10, 2024 · 4 comments · Fixed by #1145
Assignees
@ArneGudermann
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability Priority: Low This issue can be considered with enough idle time.
Milestone
ViUR-core v3.7

Comments

@akelch
Copy link
Member

akelch commented Apr 10, 2024

compute parameter will be ignored by keybone
@ArneGudermann
Copy link
Contributor

I know because the Keybone don't call the unserialize or serialize methods. Let's talk about this in the viur-meeting on friday

@ArneGudermann ArneGudermann added the viur-meeting Issues to discuss in the next ViUR meeting label Apr 10, 2024
@sveneberth sveneberth added this to the ViUR-core v3.6 milestone Apr 12, 2024
@sveneberth sveneberth added bug(fix) Something isn't working or address a specific issue or vulnerability Priority: High After critical issues are fixed, these should be dealt with before any further issues. labels Apr 12, 2024
@sveneberth sveneberth added Priority: Low This issue can be considered with enough idle time. and removed Priority: High After critical issues are fixed, these should be dealt with before any further issues. viur-meeting Issues to discuss in the next ViUR meeting labels Apr 12, 2024
@sveneberth
Copy link
Member

@ArneGudermann Please outsource the compute logic from BaseBone.serialize() to sth like BaseBone.serialize_compute() as discussed in the ViUR meeting.

@ArneGudermann ArneGudermann mentioned this issue Apr 18, 2024
Merged
@phorward
Copy link
Member

Might this become resolved by #1204?

@phorward phorward linked a pull request Oct 16, 2024 that will close this issue
feat: Add serialize_compute and unserialize_compute to BaseBone #1145
Merged
phorward added a commit that referenced this issue Oct 16, 2024
@ArneGudermann @sveneberth @phorward
feat: Add serialize_compute and unserialize_compute to BaseBone (…
a39cdc9 
…#1145)

fix for #1138

---------

Co-authored-by: Sven Eberth <[email protected]>
Co-authored-by: Jan Max Meyer <[email protected]>
@phorward
Copy link
Member

Should be fixed by #1145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArneGudermann ArneGudermann

Labels
bug(fix) Something isn't working or address a specific issue or vulnerability Priority: Low This issue can be considered with enough idle time.
Projects
None yet
Milestone
ViUR-core v3.7
Development

Successfully merging a pull request may close this issue.

feat: Add serialize_compute and unserialize_compute to BaseBone ArneGudermann/viur-core
4 participants
@sveneberth @phorward @akelch @ArneGudermann