Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add serialize_compute and unserialize_compute to BaseBone #1145

Merged
merged 12 commits into from
Oct 16, 2024
Merged

feat: Add serialize_compute and unserialize_compute to BaseBone #1145

merged 12 commits into from
Oct 16, 2024

Conversation

ArneGudermann
Copy link
Contributor

fix for #1138

@ArneGudermann ArneGudermann added the Priority: Medium This issue may be useful, and needs some attention. label Apr 18, 2024
@ArneGudermann ArneGudermann added this to the ViUR-core v3.7 milestone Apr 18, 2024
@phorward phorward added the bug(fix) Something isn't working or address a specific issue or vulnerability label Apr 29, 2024
sveneberth
sveneberth requested changes May 3, 2024
View reviewed changes
src/viur/core/bones/base.py Outdated Show resolved Hide resolved
src/viur/core/bones/base.py Outdated Show resolved Hide resolved
sveneberth
sveneberth previously approved these changes May 17, 2024
View reviewed changes
phorward
phorward requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@phorward phorward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArneGudermann can you please fix the conflicts with the current develop branch, so we can merge this?

phorward
phorward requested changes Sep 19, 2024
View reviewed changes
src/viur/core/bones/base.py Outdated Show resolved Hide resolved
src/viur/core/bones/base.py Outdated Show resolved Hide resolved
@phorward phorward added Priority: High After critical issues are fixed, these should be dealt with before any further issues. and removed Priority: Medium This issue may be useful, and needs some attention. labels Oct 14, 2024
sveneberth
sveneberth previously requested changes Oct 15, 2024
View reviewed changes
src/viur/core/bones/base.py Outdated Show resolved Hide resolved
src/viur/core/bones/base.py Outdated Show resolved Hide resolved
@phorward phorward changed the title feat: Add serialize_compute and unserialize_compute feat: Add serialize_compute and unserialize_compute to BaseBone Oct 16, 2024
phorward
phorward previously approved these changes Oct 16, 2024
View reviewed changes
@phorward phorward linked an issue Oct 16, 2024 that may be closed by this pull request
compute not working with keybones. #1138
Closed
@phorward phorward dismissed sveneberth’s stale review October 16, 2024 09:29

Fixed by ArneGudermann, approved previously

@phorward phorward merged commit a39cdc9 into viur-framework:develop Oct 16, 2024
3 checks passed
@phorward phorward mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phorward phorward phorward left review comments

@sveneberth sveneberth Awaiting requested review from sveneberth

Assignees
No one assigned
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
Documentation
Status: Todo
Milestone
ViUR-core v3.7
Development

Successfully merging this pull request may close these issues.

compute not working with keybones.
3 participants
@ArneGudermann @sveneberth @phorward