Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add UidBone #1131

Merged
merged 20 commits into from
Oct 16, 2024
Merged

feat: Add UidBone #1131

merged 20 commits into from
Oct 16, 2024

Conversation

ArneGudermann
Copy link
Contributor

Proposal for #1117

@ArneGudermann ArneGudermann added the viur-meeting Issues to discuss in the next ViUR meeting label Apr 11, 2024
@ArneGudermann
Copy link
Contributor Author

Some Points for the viur meeting

  1. should the value for an add be rendered out?
  2. readonly ?
  3. lang/multiple allowed?

@sveneberth sveneberth linked an issue Apr 12, 2024 that may be closed by this pull request
Implement UidBone #1117
Closed
@ArneGudermann ArneGudermann removed the viur-meeting Issues to discuss in the next ViUR meeting label Apr 18, 2024
@ArneGudermann ArneGudermann marked this pull request as ready for review April 18, 2024 08:05
sveneberth
sveneberth requested changes Jul 15, 2024
View reviewed changes
src/viur/core/bones/uid.py Outdated Show resolved Hide resolved
src/viur/core/bones/uid.py Outdated Show resolved Hide resolved
src/viur/core/bones/uid.py Outdated Show resolved Hide resolved
src/viur/core/bones/uid.py Outdated Show resolved Hide resolved
src/viur/core/bones/uid.py Outdated Show resolved Hide resolved
src/viur/core/bones/uid.py Outdated Show resolved Hide resolved
src/viur/core/bones/uid.py Outdated Show resolved Hide resolved
src/viur/core/bones/uid.py Outdated Show resolved Hide resolved
@ArneGudermann
Copy link
Contributor Author

mhh i have found an interesting bug. So if I call up a skel view in which this bone exists but it has not yet been written, a uid is automatically assigned but not written in the skel. This leads to the number not being used.

@ArneGudermann ArneGudermann added viur-meeting Issues to discuss in the next ViUR meeting and removed viur-meeting Issues to discuss in the next ViUR meeting labels Aug 1, 2024
@ArneGudermann
Copy link
Contributor Author

mhh i have found an interesting bug. So if I call up a skel view in which this bone exists but it has not yet been written, a uid is automatically assigned but not written in the skel. This leads to the number not being used.

Fixed by: 041da3b

sveneberth
sveneberth previously approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@sveneberth sveneberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked in my test, but I didn't any pentest. But tests in production are usually the best test anyways 😆

phorward
phorward requested changes Sep 18, 2024
View reviewed changes
src/viur/core/bones/uid.py Outdated Show resolved Hide resolved
src/viur/core/bones/uid.py Show resolved Hide resolved
src/viur/core/bones/uid.py Outdated Show resolved Hide resolved
src/viur/core/bones/uid.py Outdated Show resolved Hide resolved
@phorward phorward added this to the ViUR-core v3.7 milestone Sep 18, 2024
@phorward phorward added the Priority: High After critical issues are fixed, these should be dealt with before any further issues. label Oct 14, 2024
phorward
phorward approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@phorward phorward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. What about @sveneberth ?

@sveneberth sveneberth changed the title feat: Add UidBone feat: Add UidBone Oct 15, 2024
sveneberth
sveneberth previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@sveneberth sveneberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. What about @sveneberth ?

still fine

phorward
phorward requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@phorward phorward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we have to clarify this.

src/viur/core/bones/uid.py Outdated Show resolved Hide resolved
@phorward phorward merged commit 4a756e5 into viur-framework:develop Oct 16, 2024
3 checks passed
@phorward phorward deleted the feat/UidBone branch October 16, 2024 06:50
@phorward phorward mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phorward phorward phorward approved these changes

@sveneberth sveneberth Awaiting requested review from sveneberth

Assignees
No one assigned
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
Documentation
Status: Todo
Milestone
ViUR-core v3.7
Development

Successfully merging this pull request may close these issues.

Implement UidBone
3 participants
@ArneGudermann @sveneberth @phorward