Contact is not in target group if no filters or no contact attributes…

… are present (#88) Co-authored-by: Denise Buder <[email protected]>
vivid-planet · Sep 11, 2024 · 494fe87 · 494fe87
1 parent 8ab1188
commit 494fe87
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/packages/api/src/target-group/target-groups.service.ts b/packages/api/src/target-group/target-groups.service.ts
@@ -35,9 +35,7 @@ export class TargetGroupsService {
         contactAttributes?: BrevoContactAttributesInterface,
         filters?: BrevoContactFilterAttributesInterface,
     ): boolean {
-        if (!contactAttributes) return false;
-
-        if (filters) {
+        if (filters && contactAttributes) {
             for (const [key, value] of Object.entries(filters)) {
                 if (!value) continue;
                 if (value.includes(contactAttributes[key])) {
@@ -49,7 +47,7 @@ export class TargetGroupsService {
             return true;
         }
 
-        return true;
+        return false;
     }
 
     public async assignContactsToContactList(