Fix contact search - do not throw an error if contact is not found (#92)

vivid-planet · Sep 12, 2024 · b1cff9b · b1cff9b
1 parent 06c18b7
commit b1cff9b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/sweet-geese-tease.md b/.changeset/sweet-geese-tease.md
@@ -0,0 +1,7 @@
+---
+"@comet/brevo-api": patch
+---
+
+Fix searching contacts
+
+Previously, Brevo returned a 400 error when an email address was not found. The implementation has been updated to correctly handle the 404 status code instead of 400. As a result, the contact search functionality now works as expected without throwing an error when no matching email address is found.
diff --git a/packages/api/src/brevo-api/brevo-api-contact.service.ts b/packages/api/src/brevo-api/brevo-api-contact.service.ts
@@ -95,8 +95,8 @@ export class BrevoApiContactsService {
             if (!contact) return undefined;
             return contact;
         } catch (error) {
-            // Brevo throws 400 error if no contact was found
-            if (isErrorFromBrevo(error) && error.response.statusCode === 400) {
+            // Brevo throws 404 error if no contact was found
+            if (isErrorFromBrevo(error) && error.response.statusCode === 404) {
                 return undefined;
             }
             throw error;