Config for unsubscribe page (Depends on: https://github.com/vivid-planet/comet-brevo-module/pull/114) #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
juliawegmayr
force-pushed
the
config-for-unsubscribe-page
branch
from
bdfafc9 to
7646ad4
Compare
juliawegmayr
changed the title
juliawegmayr
force-pushed
the
config-for-unsubscribe-page
branch
from
7646ad4 to
b7bb3d9
Compare
raphaelblum
reviewed
Jan 9, 2025
|
|
||
| export class Migration20241024075236 extends Migration { | ||
| async up(): Promise<void> { | ||
| this.addSql('alter table "EmailCampaign" add column "unsubscriptionPageId" text null;'); |
There was a problem hiding this comment.
I would put the Migration files all in one file when it's in one MR.
| @@ -76,6 +77,10 @@ export function createEmailCampaignEntity({ | |||
| @Field(() => Date, { nullable: true }) | |||
| scheduledAt?: Date; | |||
|
|
|||
| @Property({ columnType: "text", nullable: true }) | |||
| @Field(() => String, { nullable: true }) | |||
| unsubscriptionPageId: string; | |||
There was a problem hiding this comment.
Is it necessary to save the unsubscriptionPageId in the EmailCampaign?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
unsubscribePageIdto BrevoConfigScreenshots/screencasts
Changeset
[ ] I have verified if my change requires a changeset
Related tasks and documents
COM-1191
Open TODOs/questions
Further information
Depends on: #114