Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor EmailCampaignEntity and TargetGroupEntity #244

Merged
merged 9 commits into from
Dec 18, 2024
Merged

Refactor EmailCampaignEntity and TargetGroupEntity #244

merged 9 commits into from
Dec 18, 2024

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Dec 3, 2024 •
edited
Loading

Description

Refactor email-campaign and target-group entities to factories as in https://github.com/vivid-planet/comet/blob/main/demo/api/src/dam/entities/dam-file.entity.ts to enable generating them in migrations.

Example

For testing the generation of the migrations, I added fields to:

  1. add "TESTFILTER" to brevo-contact-attributes
Screenshot 2024-12-10 at 10 49 54
  1. add "country" in scope
Screenshot 2024-12-10 at 10 59 59

Changeset

[x] I have verified if my change requires a changeset

Related tasks and documents

https://vivid-planet.atlassian.net/browse/COM-1010

@juliawegmayr juliawegmayr self-assigned this Dec 3, 2024
@juliawegmayr juliawegmayr marked this pull request as ready for review December 3, 2024 11:46
@auto-assign auto-assign bot requested a review from raphaelblum December 3, 2024 11:46
@juliawegmayr juliawegmayr requested review from RainbowBunchie and raphaelblum and removed request for raphaelblum December 3, 2024 11:46
@juliawegmayr juliawegmayr marked this pull request as draft December 4, 2024 11:42
@juliawegmayr juliawegmayr force-pushed the refactor-email-campaign-and-target-group-entity branch from d55fe3a to 5f0f419 Compare December 10, 2024 09:30
@juliawegmayr juliawegmayr marked this pull request as ready for review December 10, 2024 10:02
RainbowBunchie
RainbowBunchie reviewed Dec 10, 2024
View reviewed changes
.changeset/happy-cups-design.md Show resolved Hide resolved
demo/api/schema.gql Outdated Show resolved Hide resolved
demo/api/src/email-campaign/email-campaign-content-scope.ts Outdated Show resolved Hide resolved
packages/api/src/brevo-module.ts Outdated Show resolved Hide resolved
packages/api/src/email-campaign/email-campaign.module.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

RainbowBunchie
RainbowBunchie approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@RainbowBunchie RainbowBunchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please wait for @raphaelblum's review before merging

@thomasdax98 thomasdax98 added this to the v3 milestone Dec 17, 2024
@juliawegmayr juliawegmayr merged commit 8ef6341 into next Dec 18, 2024
2 checks passed
@juliawegmayr juliawegmayr deleted the refactor-email-campaign-and-target-group-entity branch December 18, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowBunchie RainbowBunchie RainbowBunchie approved these changes

@raphaelblum raphaelblum raphaelblum approved these changes

Assignees

@juliawegmayr juliawegmayr

Labels
None yet
Projects
None yet
Milestone
v3
Development

Successfully merging this pull request may close these issues.
4 participants
@juliawegmayr @RainbowBunchie @raphaelblum @thomasdax98