add example implementation of salutation placeholders in demo #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliawegmayr
force-pushed
the
add-salutation-to-demo
branch
from
a3e586a to
af9c72f
Compare
juliawegmayr
requested review from
RainbowBunchie and
raphaelblum
and removed request for
raphaelblum
| const placeholders = [ | ||
| { | ||
| placeholder: "{{SALUTATION}}", | ||
| helper: <FormattedMessage id="newsletter.richText.placeholder.salutation" defaultMessage="Dear Mr./Ms.LASTNAME" />, |
There was a problem hiding this comment.
Suggested change
| helper: <FormattedMessage id="newsletter.richText.placeholder.salutation" defaultMessage="Dear Mr./Ms.LASTNAME" />, | |
| helper: <FormattedMessage id="cometBrevoModule.richText.placeholder.salutation" defaultMessage="Dear Mr./Ms. LASTNAME" />, |
| <RichTextBlock.AdminComponent {...rteAdminComponentProps} /> | ||
| </Box> | ||
| <FormLabel> | ||
| <FormattedMessage id="newsletter.richText.placeholder.info" defaultMessage="Placeholders available in the text" /> |
There was a problem hiding this comment.
Suggested change
| <FormattedMessage id="newsletter.richText.placeholder.info" defaultMessage="Placeholders available in the text" /> | |
| <FormattedMessage id="cometBrevoModule.richText.placeholder.info" defaultMessage="Placeholders available in the text" /> |
Comment on lines
+7
to
+11
| export const getPreparedHtml = (html: string) => { | ||
| return html | ||
| .replace(new RegExp(HIDE_IN_OUTLOOK_START_IF, "g"), "<!--[if !mso]><!-- -->") | ||
| .replace(new RegExp(HIDE_IN_OUTLOOK_END_IF, "g"), "<!--<![endif]-->"); | ||
| }; |
There was a problem hiding this comment.
Why is this needed for the placeholders? Won't they be replaced via brevo anyways or am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an example on how to implement the salutation placeholder in RichTextBlock in demo.
Screenshots/screencasts
Admin:
Newsletter - Female:
Newsletter - Male:
Newsletter - No salutation filter selected:
Changeset
[x] I have verified if my change requires a changeset
Related tasks and documents
(https://vivid-planet.atlassian.net/browse/COM-1032)