Add sendingState filter in EmailCampaignsGrid #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliawegmayr
changed the title
Comment on lines
+669
to
+680
| sendingState: SendingStateEnumFilter | ||
| scheduledAt: DateFilter | ||
| and: [EmailCampaignFilter!] | ||
| or: [EmailCampaignFilter!] | ||
| } | ||
|
|
||
| input SendingStateEnumFilter { | ||
| isAnyOf: [SendingState!] | ||
| equal: SendingState | ||
| notEqual: SendingState | ||
| } | ||
|
|
There was a problem hiding this comment.
The schema changes of the packages/api/schema.gql are missing in this PR, they should be here as wenn
There was a problem hiding this comment.
Added here: da1a0ef after fixing generate-scheme file in the main branch.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The column
sendingStatein theEmailCampaignsGridshould be filterable.Screenshots/screencasts
Screen.Recording.2024-12-13.at.13.12.10.mov
Changeset
[x] I have verified if my change requires a changeset
Related tasks and documents
https://vivid-planet.atlassian.net/browse/COM-1451
Further information
As you can see in the screencast, the
is notfilter option is not working correctly. This bug will be fixed in Comet.